Improve lexing of nested data structures in PowerShell lexer #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pekspro Thanks for reporting the error. I've done a bit more refactoring and it now looks to me like the example structure you provided is working 🎉 |
|
Thank you for spending time solving my issues, @pyrmont. I have huge respect for what you are doing. |
jneen
reviewed
Nov 9, 2020
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
…uby#1622) While rouge-ruby#1595 improved the lexing of more complex structures, the PowerShell lexer is limited in its support for nested data structures. This commit moves more of the syntax for representing values from the `:root` state to the `:expr` state so that this syntax can work when nested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #1595 improved the lexing of nested data structures, the PowerShell lexer still struggles with nested data structures (as reported in #1612). This PR moves more of the syntax for representing values from the
:rootstate to the:exprstate so that this syntax can work when nested.This fixes #1612.