[cpp] fix cpp binary literal digit separator #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
approved these changes
Nov 9, 2020
|
@swheaton Thanks for fixing this 🎉 Must have come across in an erroneous copy and paste. This will be included in the next release of Rouge, v3.25.0. That is scheduled for release on Tuesday 10 November. |
|
👍 👍 |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
The C++ lexer uses `_` as a digit separator for binary literals. This is syntactically incorrect. The digit separator in C++ is `'`. This commit fixes that error. Co-authored-by: Stuart <stuart.wheaton@jhuapl.edu> Co-authored-by: Michael Camilleri <mike@inqk.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with digit separators (') in binary literals in C++. Separator character is ' not _.