Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix.kotlin.reified #1504

Merged
merged 2 commits into from Apr 17, 2020
Merged

Fix.kotlin.reified #1504

merged 2 commits into from Apr 17, 2020

Conversation

goodhoko
Copy link
Contributor

Two fixes/extensions for the Kotlin lexer.

@pyrmont pyrmont self-assigned this Apr 17, 2020
@pyrmont pyrmont added the author-action The PR has been reviewed but action by the author is needed label Apr 17, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Apr 17, 2020

@goodhoko Thanks for contributing this PR! It looks good to me. Is there anything else you wanted to add?

@goodhoko
Copy link
Contributor Author

goodhoko commented Apr 17, 2020 via email

@pyrmont pyrmont merged commit 2b704db into rouge-ruby:master Apr 17, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Apr 17, 2020

@goodhoko Thanks again! We pushed out a new gem earlier this week so unfortunately this won't be released until v3.19.0. That's scheduled for release on Tuesday 12 May.

mattt pushed a commit to NSHipster/rouge that referenced this pull request May 21, 2020
Kotlin allows three keywords to be used inside a list of generic
parameters: `in`, `out` and `reified`. In addition, it supports the use
of `:`. This commit adds support for these elements to the Kotlin lexer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-action The PR has been reviewed but action by the author is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants