Support dictionary indexers on nested properties in F# lexer #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mlapierre I have no familiarity with F# and so have implemented what may be an overly naïve fix. What do you think? |
|
@pyrmont Thanks, but unfortunately I have no familiarity with it either! I'll ask the user who reported it to me to take a look 😀 |
|
@mlapierre Cheers! |
|
<- Original reporter here It looks correct to me, but I'm not very familiar with rouge. The only cases in F# where a let value = array.[0]
let value = dict.Test.["key"] |
|
@seanamosw Thanks! Have tested it with an update visual sample and it's now merged in. It will be available in the version 3.18.0 release of Rouge. We're expecting to push that out on Tuesday 14 April. I am not sure when GitLab will decide to upgrade to that so you'll have to check with them about that. |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 21, 2020
…uby#1482) A dictionary indexer on a nested property currently breaks the F# lexer. This commit adds support for these indexers by treating the `[` as a character that triggers the `:dotted` state to be popped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dictionary indexer on a nested property currently breaks the F# lexer. This PR adds support for this by popping the
:dottedstate when a[is encountered.This fixes #1480.