Fix tokenization of compact Ruby class names #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
@ashmaroli I was going to say that I didn't think that it was correct to refer to A::B as the class name but that is the result you get when you call #name on a class defined with either syntax so looks good to me.
|
Thanks for reviewing @pyrmont |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 21, 2020
The Ruby lexer currently tokenises compact class names differently to how they are tokenised if nested. This commit makes both results consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1469
(Note: I felt highlighting the entire name reference as
Name.Classtoken would look better instead of highlighting just the class name proper.)Before
After