Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rego file parser #1468

Merged
merged 5 commits into from Apr 5, 2020
Merged

rego file parser #1468

merged 5 commits into from Apr 5, 2020

Conversation

deltamualpha
Copy link
Contributor

@deltamualpha deltamualpha commented Mar 24, 2020

  • Add lexer for Rego, which is a datalog-like language used to write policy files for authentication/authorization.
  • Reference taken from the official Rego.tmLanguage as well as the prolog lexer (very similar language). It's a pretty simple implementation!
  • This will close Support for Rego #1435.

@pyrmont pyrmont self-assigned this Mar 24, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Mar 24, 2020
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! It's looking pretty good. Please see the comments below and let me know if anything is unclear!

lib/rouge/demos/rego Outdated Show resolved Hide resolved
lib/rouge/lexers/rego.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rego.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rego.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rego.rb Show resolved Hide resolved
lib/rouge/lexers/rego.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rego.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rego.rb Outdated Show resolved Hide resolved
spec/visual/samples/rego Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Mar 24, 2020
deltamualpha and others added 2 commits March 24, 2020 14:25
Co-Authored-By: Michael Camilleri <mike@inqk.net>
@deltamualpha
Copy link
Contributor Author

Committed the rest of the changes. Do I need to smush this down to a single commit?

@pyrmont
Copy link
Contributor

pyrmont commented Mar 31, 2020

@deltamualpha No need to squash! I do that when I merge and it's more helpful for code review here to have all the commits. Thanks for checking, though! :D

@pyrmont pyrmont merged commit ba53ef8 into rouge-ruby:master Apr 5, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Apr 5, 2020

@deltamualpha Thanks for the submission :) This will be part of the next version of Rouge. That's scheduled for release on Tuesday 14 April 🎉

@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Apr 5, 2020
@deltamualpha deltamualpha deleted the rego branch April 6, 2020 14:05
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 21, 2020
This commit adds a lexer for the Rego open policy agent policy language.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Rego
2 participants