Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lpr filename #1466

Merged
merged 3 commits into from Mar 24, 2020
Merged

Added lpr filename #1466

merged 3 commits into from Mar 24, 2020

Conversation

Morabaraba
Copy link
Contributor

Added Lazarus Program file; contains Pascal source of main program.

As noted by original pull request #349 no other flavors of pascal get syntax highlighted.

#500 shows one can use .gitattributes to select the language. But Lazarus is relatively popular and there is a bunch of gitlab repo with .lpr ext that is not getting highlighted.

If I should be rather raising this issue on gitlab please let me know where.

Thanks,

Added Lazarus Program file; contains Pascal source of main program.
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Morabaraba Thanks for submitting the PR! One requested change.

lib/rouge/lexers/pascal.rb Show resolved Hide resolved
@pyrmont pyrmont self-assigned this Mar 24, 2020
@pyrmont pyrmont added the author-action The PR has been reviewed but action by the author is needed label Mar 24, 2020
Add a test to the lexer spec to check the lazarus program file extension.
add a test to the lexer spec for lpr
@pyrmont pyrmont merged commit 389c531 into rouge-ruby:master Mar 24, 2020
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Mar 24, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Mar 24, 2020

Thanks for the PR! This will go out as part of the next version of Rouge. That is scheduled for release on Tuesday 14 April :)

@Morabaraba Morabaraba deleted the patch-1 branch March 25, 2020 07:25
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 21, 2020
This commit adds the `*.lpr` file glob to the Pascal lexer. The `.lpr`
extension is used in modern Pascal for the final program file in a
Pascal project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants