Enable multi-line links in Markdown #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The markdown standard allows for link text split over multiple lines. This expands the link regex to enable this.
|
For reference, this is how it currently renders on rouge.jneen.com:
|
|
@Ravlen Sorry for the radio silence :( I've been spending time on some other projects but will get back to getting through these soon! |
|
Don't worry about it! Take your time, I'm in no hurry!
FYI, I updated GitLab's Rouge version to the latest and it's now in
production. The little tweaks we added are working in our markdown files,
and they are looking great! It's been a great first experience for me!
|
pyrmont
reviewed
Mar 24, 2020
pyrmont
added
author-action
|
@pyrmont OK, returned it back to the original, so the update only contains the fix for multi-line link text now. I'll update the description. |
pyrmont
approved these changes
Mar 25, 2020
|
@Ravlen Thanks for another fix! |
pyrmont
removed
the
author-action
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 21, 2020
While Markdown is supposed to alow link text to span multiple lines, the lexer in Rouge did not support it. This commit enables that support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1450
The markdown standard allows for link text split over multiple lines. This expands the
link regex to enable this.
While I was there, I also allowed for a space between links and link references as well, which is allowed in the spec, and added an example to the markdown test for that as well.Edit: Reverted this change, as per discussion.When tested with
rackup:cc @pyrmont