Revert Rubocop splat expansion cop #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pyrmont A minor correction to the opening post: |
|
@ashmaroli Corrected, thanks! |
|
@pyrmont You're welcome. But may I ask why this change is considered significant enough to warrant a patch release? |
|
Yeah, agreed it doesn't require a patch release. Would still like it merged into master as soon as possible, though. |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 21, 2020
This commit reverses the change made in rouge-ruby#1451 and changes the name of the cop back to `UnneededSplatExpansion`. The reason to do this is that Rouge supports versions of Ruby from 2.0 and this prevents upgrading our development dependencies to a newer version of RuboCop (RuboCop ended support for versions prior to v2.3 with RuboCop v0.50). The renamed cop was not introduced until RuboCop v0.76. Dropping support for older versions of Ruby may be implemented as part of Rouge v4.0 but it won't occur as part of v3.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverses the change made in #1451. The problem is support for versions of Ruby prior to v2.3. RuboCop ended support for these versions with RuboCop v0.50 but Rouge has not. (The renamed cop was not introduced until RuboCop v0.76.) Dropping support for older versions of Ruby may be implemented as part of Rouge v4.0 but it won't occur as part of v3.0.