New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
varnish: support Fastly's dialect #1454
Conversation
Thank you! |
I have also renamed the language name from "Varnish" to "VCL" in 7886c6d This is because the right name of the language is called "VCL", standing for "Varnish Configuration Language", whereas "Varnish" is the name of the HTTP server. However, the interface does not change, by keeping aliases and mime types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have had more of a fuller review. Some additional questions:
Thanks! |
This commit adds support for Fastly's extensions to the Varnish configuration language (a.k.a. VCL). Fastly's VCL is proprietary, closed-source software but because (1) the primary users are outside the company, and (2) Rouge already includes some proprietary dialects in other lexers, this was deemed to be acceptable.
Added Fasty's extension for Varnish configuration language (a.k.a. VCL). Fastly's VCL is proprietary, closed-source software but I think it is worth adding to the core because (1) the primary users are outside the company, and (2) some lexers have dialects of proprietary, closed-source software like Oracle for SQL.
This PR includes some bug fixes.
The complete reference of Fastly's VCL is here: https://docs.fastly.com/vcl/
test commands:
bundle exec bin/rougify highlight -m text/x-vcl spec/visual/samples/vcl