Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsonc alias to JSONDOC lexer #1440

Merged
merged 1 commit into from Apr 3, 2020

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Feb 16, 2020

GitHub supports the use of the jsonc info string to permit comments in JSON. The Rouge JSONDOC lexer provides a lexer that would lex this correctly but which does not support the use of jsonc as an alias. This PR adds that alias.

This fixes #1028.

@pyrmont pyrmont self-assigned this Feb 16, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Feb 16, 2020
@pyrmont pyrmont merged commit 9675b04 into rouge-ruby:master Apr 3, 2020
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Apr 3, 2020
@pyrmont pyrmont deleted the bugfix.json_doc-add-jsonc-alias branch April 3, 2020 21:30
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 21, 2020
GitHub supports the use of the `jsonc` info string to permit comments
in JSON. The Rouge JSONDOC lexer provides a lexer that would lex this
correctly but which does not support the use of `jsonc` as an alias.
This commit adds that alias.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support JSON With Comments
1 participant