Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ruby 2.7 warnings in check:memory Rake task #1431

Merged
merged 1 commit into from Apr 3, 2020
Merged

Fix Ruby 2.7 warnings in check:memory Rake task #1431

merged 1 commit into from Apr 3, 2020

Conversation

ashmaroli
Copy link
Contributor 

/home/travis/build/rouge-ruby/rouge/tasks/check/memory.rake:21: warning: Using the last
argument as keyword parameters is deprecated; maybe ** should be added to the call
/home/travis/build/rouge-ruby/rouge/vendor/bundle/ruby/2.7.0/gems/memory_profiler-0.9.14/lib/
memory_profiler/results.rb:110: warning: The called method `pretty_print' is defined here

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Feb 11, 2020
@pyrmont pyrmont self-assigned this Feb 11, 2020
@pyrmont pyrmont merged commit 5213a03 into rouge-ruby:master Apr 3, 2020
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Apr 3, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Apr 3, 2020

Sorry this took so long to get to, @ashmaroli. Thanks for submitting the fix!

@ashmaroli ashmaroli deleted the memprof-Ruby2.7-warnings branch April 5, 2020 07:11
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 21, 2020
@ashmaroli @mattt
Fix Ruby keyword warning in check:memory Rake task (rouge-ruby#1431)
63436f8 
As of Ruby 2.7, warnings are generated when the `check:memory` Rake task
is run due to the use of a Hash object as an argument. This commit omits
the use of the Hash object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrmont pyrmont pyrmont approved these changes

Assignees

@pyrmont pyrmont

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashmaroli @pyrmont