Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Unicode identifiers in Java lexer #1414

Merged
merged 3 commits into from Feb 1, 2020

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Jan 27, 2020

Identifiers used in Java can include Unicode characters; however, the Java lexer only matches against ASCII identifiers. This PR adds support for Unicode characters using Ruby's broader character classes.

This fixes #831.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jan 27, 2020
@pyrmont pyrmont self-assigned this Jan 27, 2020
@pyrmont pyrmont merged commit 988414a into rouge-ruby:master Feb 1, 2020
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Feb 1, 2020
@pyrmont pyrmont deleted the bugfix.java-unicode-ids branch April 27, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken java highlighting
1 participant