Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature.terminal truecolor #1413

Merged
merged 9 commits into from Jan 27, 2020
Merged

Feature.terminal truecolor #1413

merged 9 commits into from Jan 27, 2020

Conversation

jneen
Copy link
Member

@jneen jneen commented Jan 26, 2020

Add support for truecolor terminals!

@jneen
Copy link
Member Author

jneen commented Jan 26, 2020

Try it out with ./bin/rougify -f terminal-truecolor some-file

@jneen
Copy link
Member Author

jneen commented Jan 26, 2020

To compare:

image

vs

image

@pyrmont pyrmont self-assigned this Jan 26, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jan 26, 2020
pyrmont
pyrmont reviewed Jan 27, 2020
View reviewed changes
lib/rouge/cli.rb Outdated Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Jan 27, 2020
pyrmont
pyrmont suggested changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't notice this myself until going over this code more closely:

lib/rouge/cli.rb Show resolved Hide resolved
@jneen jneen merged commit af801f8 into master Jan 27, 2020
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jan 27, 2020
@tancnle tancnle deleted the feature.terminal-truecolor branch September 22, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrmont pyrmont pyrmont approved these changes

Assignees

@pyrmont pyrmont

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jneen @pyrmont