Support '"' to identify heredoc delimiters in Shell lexer #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like it fixes the problem on my end, @Cartoonman. How's it look to you? |
|
Tried your patch on my local instance and LGTM. Thanks @pyrmont! |
|
@Cartoonman Sweet! Thanks for the report :) We release new versions of Rouge on a monthly cadence at the moment. Version 3.16.0 will have this change incorporated and is scheduled to be pushed out on Tuesday 11 February. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heredoc delimiters in the Shell lexer can be identified by the use of
'. This PR adds support for the use of".This fixes #1409.