Fix NameError on @ + UPPERCASE token in Objective-C #1406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an error when highlighting
@FOO
as Objective-C.This pull request will fix the problem.
I guess this error is related to #1378. Because this PR introduced the
base
variable.By the way, I'm not sure I should write test code for this fix.
I guess we can add it to
spec/visual/samples/objective_c
, but I don't know Objective-C syntax.And it is highlighted as "Error", so I'm wondering if the visual test should contain it.
Please tell me how to write a test if it's necessary 🙇♂️