Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jinja comments that contain code #1386

Merged
merged 4 commits into from Jan 8, 2020

Conversation

shermdog
Copy link
Contributor

@shermdog shermdog commented Jan 7, 2020

This commit allows for Jinja code to be properly commented out

Before
image

After
image

This commit allows for Jinja code to be properly commented out
@pyrmont pyrmont self-assigned this Jan 7, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jan 7, 2020
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR as well! I've got a question about how comments work in Jinja below:

lib/rouge/lexers/jinja.rb Outdated Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Jan 7, 2020
@pyrmont pyrmont merged commit 39ec4a4 into rouge-ruby:master Jan 8, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Jan 8, 2020

@shermdog Thanks for the contribution! This change will be part of v3.15.0 of Rouge. That's scheduled for release on Tuesday 14 January 🎉

@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants