GHC Core

[supersven]

Add Lexer for GHC Core

Core is an intermediate language of the Glasgow Haskell Compiler.

[pyrmont]

This looks like a really impressive lexer! Thanks for submitting the PR. I've left some comments above. Let me know if anything is unclear :)

In addition, could you cut down the size of the visual sample? It's too long at the moment. Ideally, it should be just enough to visually test the rules.

[pyrmont]

@supersven Sorry, one minor change: I renamed the class to be a little more consistent with the general approach taken with Rouge's lexers. It's not always universally followed but it should be done this way.

[supersven]

Hey @pyrmont ,

Thanks a lot for the review and your changes!

I forgot to mention one thing: If you like, you can squash the commits during merge. I think that my "baby step" commits might be more confusing than helping in the long run ... 😄

[pyrmont]

@supersven Yep, I always squash the PR commits into a single commit before merging. Helps to keep the commit history nice and clean :) Thanks again for all the work! 🎉

The next version of Rouge will be out on Tuesday 14 January. This will be part of that release :)

[supersven]

@pyrmont ,
Fantastic! Thanks a lot for the review! 👍