Clean up LLVM lexer #1376
Merged
Clean up LLVM lexer #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jholewinski I added the string from the issue to the visual sample and it's lexing correctly now on my system. Does everything look OK to you? |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The impetus for cleaning up the LLVM lexer was the failure to properly match keywords as discussed in #1372. Partly this was due to a keyword missing but partly it was due to the use of
String#jointo create brittle regex patterns.This PR uses memoising singleton methods and the use of
Array#include?to match against a set of keywords. Doing this reduces memory usage by only allocation the keyword strings when the method is called, allows for the keywords to be ordered alphabetically which aids in legibility and, frankly, just looks nicer.Finally, the
addrspacecastkeyword is added.This fixes #1372.