Fix Liquid's pattern for matching include tag's filename argument #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
suggested changes
Oct 16, 2019
pyrmont
added
the
author-action
pyrmont
approved these changes
Nov 29, 2019
pyrmont
removed
the
author-action
|
Thanks again for this, @EricFromCanada! We've moved to a monthly release schedule now. This will be part of the version that'll be pushed out on 12 December :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Liquid lexer, this line in the
:includestate is specific to Jekyll's implementation of theincludetag, which allows specifying an unquoted file path as the initial argument, much like its owninclude_relativetag. This changes the rule to only allow a specific set of characters (including slash, because the tag searches subdirectories) which fixes a code sample in this section, and marks the argument as plainTextto match howinclude_relativeis handled.