Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Phoenix Live View (Live EEx) #1347

Merged
merged 2 commits into from Oct 12, 2019

Conversation

vermaxik
Copy link
Contributor

Since Phoenix Live View become more a more popular,
I would like to see highlight source code in GitLab/GitHub for *.leex extensions.

Basically it alias for *.eex, that a reason why it was added in existing lexers.

@pyrmont pyrmont self-assigned this Oct 12, 2019
@pyrmont pyrmont merged commit b357204 into rouge-ruby:master Oct 12, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Oct 12, 2019

Thanks for the PR @vermaxik! :)

I should note:

  • GitHub used to use Rouge for syntax highlighting but now uses its own code so unfortunately this won't help there. To have GitHub syntax highlight .leex files as Embedded Elixir, you'll need to submit a PR to GitHub's Linguist library (I'm not very familiar with this project but I think this is the file you need to edit).

  • GitLab does use Rouge, though, and once they upgrade to the version of Rouge that incorporates this PR, it should start working there. We're on a two-week cadence for releases and the next version is due out this coming Tuesday.

@vermaxik
Copy link
Contributor Author

Thank you @pyrmont

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants