Update BPF lexer #1346
Merged
Update BPF lexer #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
added
author-action
Signed-off-by: Paul Chaignon <paul.chaignon@orange.com>
Signed-off-by: Paul Chaignon <paul.chaignon@orange.com>
Signed-off-by: Paul Chaignon <paul.chaignon@orange.com>
Signed-off-by: Paul Chaignon <paul.chaignon@orange.com>
pchaigno
force-pushed
the
update-bpf-lexer
branch
from
3141501
to
e6079bd
Compare
|
@pchaigno Thanks for adding this support and I'm sorry I didn't get it into master before cutting the v3.12.0 release :( We're about to move to a monthly release schedule for new versions of Rouge so I'm afraid there'll be a bit of a wait. The next version is scheduled to be released on 12 November. Thanks again for contributing to Rouge! |
pyrmont
removed
the
author-action
No problem. It takes many months to update the dependencies in GitHub Pages gem anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the BPF lexer to support several constructs from the two main disassemblers, bpftool and objdump:
w4syntax for registers used in 32bit ALU instructions.map[id:671]to refer to pointer to the map with id 671.call bpf_skb_load_bytes#7684912to refer to a call to helper bpf_skb_load_bytes.(bf)and61 12 04 00 00 00 00 00for the hexadecimal encoding of the opcode and instruction respectively.I'm adding basic support for the hexadecimal output (
Genericgroup) so that it doesn't break highlighting. By supporting this, we make it easier for users to directly highlight the output of bpftool and objdump. I've updated the sample file with raw outputs from both bpftool and objdump.