Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash code like $'\0' breaks syntax highlighting #698

Closed
selivan opened this issue Jun 13, 2017 · 3 comments
Closed

bash code like $'\0' breaks syntax highlighting #698

selivan opened this issue Jun 13, 2017 · 3 comments

Comments

@selivan
Copy link

selivan commented Jun 13, 2017

Steps to reproduce

Public a page where bash code block contains $'\0'(bash-specific way to use string with escaped unprintable characters):

```bash
null=$'\0';
echo all further code is highlighted as string
```

Expected result

See correct highlighting: $'\0' is string, characters after closing ' are not.

Actual result

All further code is displayed as string until parser stumbles upon single quote ' character.

Additional information

Live site on github pages with this problem: selivan.github.io - ansible-check-on-commit-vault-files-are-encrypted.

First I contacted github-pages guys about this issue: github/pages-gem#436, they sent me to upstream.

@selivan selivan changed the title bash code like $'\0' breaks syntax highlighting for rouge highlighter bash code like $'\0' breaks syntax highlighting Jun 13, 2017
@jneen
Copy link
Member

jneen commented Jun 13, 2017

Can you see if you can reproduce this using master? I think the github-pages folks might be on a super-ancient version.
2017-06-13 jun 06 1497389727_555x164

@selivan
Copy link
Author

selivan commented Jun 13, 2017

@jneen yep, it's not reproduced with 2.1.0 version, ancient bug it is.

You mentioned(jekyll/jekyll#5919 (comment)), that you are getting a lot of issues for rouge 1.x. I suppose you can add an issue template(https://help.github.com/articles/creating-an-issue-template-for-your-repository/) to this repository, mentioning that. So jekyll users will stop bothering you and will start bothering jekyll guys to update to supported rouge version.

@selivan selivan closed this as completed Jun 13, 2017
@jneen
Copy link
Member

jneen commented Jun 13, 2017

Haha yep, that would be helpful. I do hope they update soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants