Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlight of nullish coalescing operator in JS #1846

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Fix highlight of nullish coalescing operator in JS #1846

merged 1 commit into from
Jul 4, 2022

Conversation

tancnle
Copy link
Collaborator

@tancnle tancnle commented Jun 30, 2022 •
edited

Fix highlight of nullish coalescing operator in JS. Before this change, this operator was picked up as the start of a ternary statement and caused issues for the subsequent string.

Before After
Screen Shot 2022-06-30 at 7 14 58 pm Screen Shot 2022-06-30 at 7 11 23 pm

Fixes #1834

@tancnle
Copy link
Collaborator Author

tancnle commented Jun 30, 2022

👋🏼 @legacy3 could you kindly review this PR and see if it addresses the reported issue? 🙏🏼

@tancnle tancnle merged commit b8e146f into rouge-ruby:master Jul 4, 2022
@tancnle tancnle deleted the bugfix.js-nullish-coalescing-operator branch July 4, 2022 11:44
@tancnle tancnle mentioned this pull request Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in JavaScript lexer
1 participant
@tancnle