Dart: Distinguish between punctuation and operators #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tancnle would you mind reviewing this PR? |
|
@gareththackeray Thanks for the ping. I will look into this sometime today. |
tancnle
reviewed
Jun 29, 2022
tancnle
reviewed
Jun 29, 2022
There was a problem hiding this comment.
Thanks for your contribution @gareththackeray ❤️ I have added a suggestion. Please let me know what you think.
tancnle
added
the
author-action
gareththackeray
force-pushed
the
dart-punctuation
branch
from
bbe2c86
to
bf4cdf5
Compare
|
Thank you for the prompt action on this @gareththackeray. Looks great to me 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All punctuation type characters were being treated as operators, except the first
(in a function signature, which led to different markup on opening versus closing parenthesis. By making all bracket type characters punctuation it will harmonise the formatting.