Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing CMake commands for CMake lexer #1630

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Add missing CMake commands for CMake lexer #1630

merged 1 commit into from
Dec 5, 2020

Conversation

gnaggnoyil
Copy link
Contributor

CMake has been adding new commands as time goes by and its development progreses. There are a few new commands available in the latest CMake release yet not recoginzed by current CMake lexer:

add_compile_definitions
add_link_options
cmake_language
cmake_parse_arguments
include_guard
target_compile_features
target_link_directories
target_link_options
target_precompile_headers
target_sources

This PR would allow CMake lexer to recoginze these commands correctly. For each command mentioned above, the earilest version that this command is available can be found in the document of latest CMake release.

@pyrmont pyrmont merged commit 7f45c7d into rouge-ruby:master Dec 5, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Dec 5, 2020

@gnaggnoyil Thanks for adding these :) Merged in!

@gnaggnoyil gnaggnoyil deleted the cmake_commands branch December 18, 2020 17:39
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
This commit adds a number of commands to the CMake lexer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants