Fix incorrect predicate usage in PowerShell lexer #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pekspro In the visual sample, I'm now seeing your example code lexing correctly. How does it look to you? |
|
Wow, this fix was done very fast. I am impressed :-) When I look on http://rouge.jneen.net it still looks like same. Could I verify this somewhere else? Or do I need to compile this? I have never worked with ruby, but I guess I could learn :-D |
|
@pekspro Yeah, unfortunately you need to download the repo and run |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
The PowerShell lexer includes rules that use the existence of a nil value in a regular expression to decide whether to push new states onto the stack. The predicates for these rules were written incorrectly. This commit removes one of the predicates (which wasn't necessary) and uses `Object#nil?` in the other to match correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PowerShell lexer includes rules that use the existence of a
nilvalue in a regular expression to decide whether to push new states onto the stack. The predicates for these rules were written incorrectly. This PR removes one of the predicates (which wasn't necessary) and usesObject#nil?in the other to match correctly.This fixes #1535.