Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RuboCop grouped expression warning in Python lexer #1513

Merged

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented May 12, 2020

The use of a ternary in code added to the Python lexer as part of the #1508 pull request results in a RuboCop warning concerning parentheses and grouped expressions. This PR fixes that warning.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label May 12, 2020
@pyrmont pyrmont self-assigned this May 12, 2020
@pyrmont pyrmont merged commit 1e32f3c into rouge-ruby:master May 12, 2020
@pyrmont pyrmont deleted the bugfix.python-rubocop-grouped-expression branch May 12, 2020 17:11
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label May 12, 2020
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 21, 2020
The use of a ternary in code added to the Python lexer as part of the
rouge-ruby#1508 pull request results in a RuboCop warning concerning parentheses
and grouped expressions. This commit fixes that warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant