Allow incorrect braces and brackets in JSON lexer #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chuck-confluent I don't know if this is too late for your use case but I think I've added a way to permit the use of braces/brackets you wanted. What do you think? |
|
Thanks @pyrmont ! Which version of Rouge I can look forward to supporting this? I'll just make a note to rebuild my docker image when it's available |
|
@chuck-confluent This will be part of the next release of Rouge, v3.18.0. That's scheduled for Tuesday 14 April (so today or tomorrow depending on where you're reading this). |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 21, 2020
The JSON lexer will currently mark closing braces and brackets as an error if they do not have a matching opening brace/bracket. As checking syntactic correctness is a non-goal of Rouge, this commit adds a rule to the `:root` state that permits these characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON lexer will mark closing braces and brackets as an error if they do not have a matching opening brace/bracket. As checking syntactic correctness is a non-goal of Rouge, this PR instead adds a rule to the
:rootstate to permits these characters.This fixes #1467.