Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the 'a' keyword in SPARQL lexer #1493

Merged
merged 3 commits into from May 12, 2020

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Apr 10, 2020

The case-sensitive keyword a is a valid keyword in SPARQL (reference). At present, the SPARQL lexer does not recognise it as such. This PR fixes that error (the rule is similar to the one used in the Turtle lexer).

This fixes #1486.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Apr 10, 2020
@pyrmont pyrmont self-assigned this Apr 10, 2020
@pyrmont
Copy link
Contributor Author

pyrmont commented Apr 10, 2020

@kaefer3000 Thanks for doing the hard work and providing so much helpful information. This is a pretty straightforward fix but if you see anything wrong, please let me know!

@pyrmont pyrmont merged commit c68336e into rouge-ruby:master May 12, 2020
@pyrmont pyrmont deleted the bugfix.sparql-a-keyword branch May 12, 2020 17:21
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label May 12, 2020
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 21, 2020
The case-sensitive keyword `a` is a valid keyword in SPARQL. At
present, the SPARQL lexer does not recognise it as such. This commit
fixes that error (the rule is similar to the one used in the Turtle lexer).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPARQL] "a" is a keyword
1 participant