Fix symbol pattern in Scala lexer #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anthony-cros How's this look to you? |
|
Conceptually the negative lookahead approach sounds reasonnable. I'm not very familiar with Ruby in general, I tried Can you maybe just show a screenshot? |
|
@anthony-cros See below:
|
|
Looks good :) |
|
@anthony-cros Thanks! This fix will be out as part of v3.17.0. That's scheduled for release on Tuesday 17 March 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scala lexer currently matches 'symbols' by ensuring that the last character in the match is not a
'.The problem with this approach is that if the symbol occurs within a lexical structure (e.g. parentheses), the first character after the symbol (e.g. the closing parenthesis) would be matched as part of the symbol.
This PR uses the approach of a negative lookahead to avoid this problem.
This fixes #374.