Clean up Varnish files #1433
Merged
Clean up Varnish files #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
commented
Feb 10, 2020
|
@blckct Thanks for submitting #1434! There are a bunch of changes that need to be made to the Varnish lexer to bring it into conformity with the way we try to write lexers now and so I created this PR to do that. I've added your keywords here. Since I'm guessing you have some familiarity with Varnish, could you have a look at the code in this PR and let me know what you think? |
julp
reviewed
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Varnish lexer was written in a style inconsistent with that used in the current version Rouge. This PR fixes those problems.