Improvements to the NASM samples #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
suggested changes
Feb 1, 2020
pyrmont
added
author-action
pyrmont
approved these changes
Feb 5, 2020
pyrmont
removed
the
author-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reviewing #483, I set out to test how complete the NASM support was.
Apparently, an issue with brackets has already been resolved.
Nonetheless, I went ahead and performed some consistency refactorings in the NASM samples (it mixed tabs with spaces, had misaligned comments, missing spaces after commas, and so on). I also added compilation instructions to the lengthier sample as it is interesting to be able to check whether or not it is a working program.