Implement an Objective-C++ lexer #1378
Conversation
|
@saagarjha Development of Rouge should involve running the automated test suite (run I've added a demo file and a visual sample that are just copies of the Objective-C demo and sample. These should be adjusted to show Objective-C++ syntax. It perhaps goes without saying but you should also check the Objective-C visual sample to make sure it's behaving as it was before the change. Hope that helps! |
pyrmont
added
author-action
saagarjha
force-pushed
the
master
branch
3 times, most recently
from
5ab90a4
to
4f909d5
Compare
pyrmont
added
needs-review
pyrmont
added
author-action
In addition, factor out the common Objective-C bits into a shared module
This makes the methods available to class directly, so we don't have to add them manually via reflection.
|
|
||
| tag 'objective_cpp' | ||
| title "Objective-C++" | ||
| desc 'an extension of C++ uncommonly used to write Apple software' |
pyrmont
removed
the
author-action
|
@saagarjha Thanks for your work on this. I've merged it into master. We release new versions of Rouge on a monthly schedule so this will be included in version 3.15.0 on Tuesday 14 January 🎉 |
|
Thanks, I look forwards to being able to use this! |
Certain objects that were extracted from the Objective-C lexer in #1378 needed to be prefaced with a `base` variable. This included the token classes. This was not done for `Error`. This commit fixes that mistake.
I tried my hand at factoring out the common Objective-C stuff into its own module, but I don't really know Ruby so the result is just me mashing scoping operators from other languages until it stopped giving me errors. Any suggestions or comments about this approach? I am fairly sure the Objective-C++ breaks on certain "mixed" constructs so I'll look into that next. Are there testcases I should write along with this?