Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starlark support #1369

Merged
merged 2 commits into from Jan 12, 2020
Merged

Starlark support #1369

merged 2 commits into from Jan 12, 2020

Conversation

zoidyzoidzoid
Copy link
Contributor

Inspired by https://github.com/pygments/pygments/pull/1259/files

Closes #1368

I'll take a look adding some test cases in the morning.

@pyrmont pyrmont self-assigned this Dec 8, 2019
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Dec 8, 2019
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and sorry for the delay in getting around to the review. See my comment above.

lib/rouge/lexers/python.rb Outdated Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Dec 18, 2019
@zoidyzoidzoid zoidyzoidzoid changed the title WIP Starlark support Starlark support Jan 12, 2020
@pyrmont pyrmont merged commit 108737b into rouge-ruby:master Jan 12, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Jan 12, 2020

Thanks for the contribution! The next release of Rouge will come out this Tuesday. The code in this PR will be available as part of that version 🎉

@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jan 12, 2020
@zoidyzoidzoid zoidyzoidzoid deleted the patch-1 branch January 20, 2020 21:35
@zoidyzoidzoid
Copy link
Contributor Author

Thanks for the great review and all your work on maintaining this project. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Bazel/Starlark
2 participants