Add support for inline tables to TOML lexer #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
changed the title
arp242
added a commit
to arp242/rouge
that referenced
this pull request
Oct 12, 2023
A TOML table looks like:
[tblname]
key = 'value'
You can also use inline tables like so:
[tblname]
key = 'value'
inline = {key = 'value'}
However, the "inline" would get highlighted as a table (same as
"[tblname]") rather than a regular key, which is very jarring and
unexpected IMHO.
It looks like it's been like this ever since inline tables were added in
rouge-ruby#1359, but I don't think anyone really wants this behaviour.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2023
A TOML table looks like:
[tblname]
key = 'value'
You can also use inline tables like so:
[tblname]
key = 'value'
inline = {key = 'value'}
However, the "inline" would get highlighted as a table (same as
"[tblname]") rather than a regular key, which is very jarring and
unexpected IMHO.
It looks like it's been like this ever since inline tables were added in
#1359, but I don't think anyone really wants this behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current TOML lexer does not support inline tables. This PR fixes that by adding a new
:inlinestate.This fixes #826.