Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MiniZinc lexer #1329

Merged
merged 7 commits into from Oct 3, 2019
Merged

Add MiniZinc lexer #1329

merged 7 commits into from Oct 3, 2019

Conversation

abevoelker
Copy link
Contributor

No description provided.

@pyrmont pyrmont self-assigned this Sep 15, 2019
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Sep 15, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Sep 29, 2019

@abevoelker Sorry it took so long to get to this >_< Hopefully the commit messages explain the rationale for the changes but if there's anything you had a question about, please let me know!

@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Sep 29, 2019
@abevoelker
Copy link
Contributor Author

abevoelker commented Oct 1, 2019

LGTM :shipit:

No need to apologize; I greatly appreciate the free labor you put into maintaining this thing I'm using, and it's not like the PR was holding me up - I can always run my branch locally. Thank you!

edit: and thanks for cleaning up my messy code!

@pyrmont pyrmont merged commit d318419 into rouge-ruby:master Oct 3, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Oct 3, 2019

@abevoelker Thanks for submitting the lexer! We couldn't cover all the languages that we do without contributions from the community :) We release new versions of Rouge on a two-week cadence so this will come out as part of v3.12.0 on 15 October 🎉

@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants