Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up pull requests - Reviewed lexer PRs #1063

Closed
vidarh opened this issue Jan 13, 2019 · 7 comments
Closed

Cleaning up pull requests - Reviewed lexer PRs #1063

vidarh opened this issue Jan 13, 2019 · 7 comments
Labels
discussion-open stale-issue There has been no activity for a year.

Comments

@vidarh
Copy link
Contributor

vidarh commented Jan 13, 2019

@dblessing, as per discussion in order to make it easier to keep track, here is a list of pull requests I've reviewed that I believe are in a ok state to get merged. I'm happy to create a single pull-request and clean-up minor issues (second list), and squash commits for these so there's one commit per lexer, if it'll help.

Lexers ok to merge as is

Lexers w/frozen-string literal comment missing and/or minor textual cleanup only

(I'm happy to clean these up if the original authors don't)

Prerequisite

Note that we should get #1062 (the CI fix) agreed and merged first, as some of the above have CI failures - all of them should only be because of the CI issue, but obviously worth verifying.

Other lexers

This leaves five new lexers I've requested changes for that I don't think are ready yet (#1021, #989, #880, #710, #876), but that can be with relatively small fixes. There's a further 17 I've reviewed where there was enough discussion or complexity that they'll need more detailed time spent on each lexer. Some of these may very well be ok but I can't tell without spending more time on them.

EDIT: Added #1037
EDIT2: Added #836 #749 and #905
EDIT3: Added #891, #884, #871, #864, #814, #789, #724

@vidarh vidarh changed the title Cleaning up pull requests Cleaning up pull requests - Reviewed lexer PRs Jan 13, 2019
@miparnisari
Copy link
Contributor

Is it possible to have this merged soon? @dblessing @vidarh

@geoffroymontel
Copy link

It would be super nice if supercollider lexer could be merged indeed, working on the new website ! best

@gferreira
Copy link

OpenTypeFeature lexer #864 should also be ready to merge… thanks!

@pyrmont
Copy link
Contributor

pyrmont commented Jul 11, 2019

@gferreira I've reviewed that PR (sorry, it fell victim to the fact I'm going through them in reverse chronological order) and have left some feedback for the author. Will wait to see how they respond.

@MedvedTMN
Copy link
Contributor

ISBL lexer #891 should also be ready to merge… thanks!

@pyrmont
Copy link
Contributor

pyrmont commented Aug 1, 2019

@MedvedTMN I've addressed #891 more fully on the discussion page for the PR.

@stale
Copy link

stale bot commented Aug 1, 2020

This issue has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.
If you would like this issue to remain open, please reply and let us know if the issue is still reproducible.

@stale stale bot added the stale-issue There has been no activity for a year. label Aug 1, 2020
@stale stale bot closed this as completed Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion-open stale-issue There has been no activity for a year.
Projects
None yet
Development

No branches or pull requests

6 participants