New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up pull requests - Reviewed lexer PRs #1063
Comments
Is it possible to have this merged soon? @dblessing @vidarh |
It would be super nice if supercollider lexer could be merged indeed, working on the new website ! best |
OpenTypeFeature lexer #864 should also be ready to merge… thanks! |
@gferreira I've reviewed that PR (sorry, it fell victim to the fact I'm going through them in reverse chronological order) and have left some feedback for the author. Will wait to see how they respond. |
ISBL lexer #891 should also be ready to merge… thanks! |
@MedvedTMN I've addressed #891 more fully on the discussion page for the PR. |
This issue has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days. |
@dblessing, as per discussion in order to make it easier to keep track, here is a list of pull requests I've reviewed that I believe are in a ok state to get merged. I'm happy to create a single pull-request and clean-up minor issues (second list), and squash commits for these so there's one commit per lexer, if it'll help.
Lexers ok to merge as is
Lexers w/frozen-string literal comment missing and/or minor textual cleanup only
(I'm happy to clean these up if the original authors don't)
Prerequisite
Note that we should get #1062 (the CI fix) agreed and merged first, as some of the above have CI failures - all of them should only be because of the CI issue, but obviously worth verifying.
Other lexers
This leaves five new lexers I've requested changes for that I don't think are ready yet (#1021, #989, #880, #710, #876), but that can be with relatively small fixes. There's a further 17 I've reviewed where there was enough discussion or complexity that they'll need more detailed time spent on each lexer. Some of these may very well be ok but I can't tell without spending more time on them.
EDIT: Added #1037
EDIT2: Added #836 #749 and #905
EDIT3: Added #891, #884, #871, #864, #814, #789, #724
The text was updated successfully, but these errors were encountered: