Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need "Control Flow Guard" Enabled On Assemblies #252

Open
JohnMarzulli opened this issue Jul 18, 2023 · 0 comments
Open

Need "Control Flow Guard" Enabled On Assemblies #252

JohnMarzulli opened this issue Jul 18, 2023 · 0 comments

Comments

@JohnMarzulli
Copy link

Problem

The internal security checks of my company enforces that all Nuget packages have "Control Flow Guard" enabled.

This is to prevent any security issues.

Proposed Solution

Enable "Control Flow Guard" in the build so Web Driver Manager may be used by more organizations.

##[error]1. BinSkim Error BA2008 - File: AcceleratorCore/bin/Release/net6.0/selenium-manager/windows/selenium-manager.exe.  
  Tool: BinSkim: Rule: BA2008 (EnableControlFlowGuard). https://github.com/microsoft/binskim/blob/main/docs/BinSkimRules.md#rule-BA2008EnableControlFlowGuard
  'selenium-manager.exe' does not enable the control flow guard (CFG) mitigation. To resolve this issue, pass /guard:cf on both the compiler and linker command lines. Binaries also require the /DYNAMICBASE linker option in order to enable CFG.

Build Environment

DotNet 6.x LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants