Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mac arm64 suffix #214

Merged
merged 1 commit into from Nov 8, 2022
Merged

Fix mac arm64 suffix #214

merged 1 commit into from Nov 8, 2022

Conversation

fmoliveira
Copy link
Contributor

This fixes the new arm64 suffix for mac releases and closes #210 . Tested on an M1 Mac.

I see the change c40bcf9 is not yet released, so I've tested it locally.

@fmoliveira
Copy link
Contributor Author

Thank you @rosolko for your earlier patch!

I tried fixing it with support for older Chrome versions at https://github.com/fmoliveira/WebDriverManager.Net/commit/c494de187f32196cf6de09ca44658c5b3c52efd3 , but figured the solution wasn't suitable because it introduced a breaking change to IDriverConfig which is public and documented in the project readme to be extendable.

@rosolko rosolko merged commit 5ed5944 into rosolko:master Nov 8, 2022
@fmoliveira fmoliveira deleted the fix-mac-arm64-suffix branch November 8, 2022 12:00
@FelixLeChat FelixLeChat mentioned this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid chromedriver download URL for Chrome 106+ on Mac M1
2 participants