Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create proxy based on environment variables #197

Merged
merged 3 commits into from Aug 15, 2022
Merged

Create proxy based on environment variables #197

merged 3 commits into from Aug 15, 2022

Conversation

jgelon
Copy link
Contributor

@jgelon jgelon commented Jul 1, 2022 •
edited

Use HTTP_PROXY / HTTPS_PROXY system variables to set the proxy instead of hardcoded during WebDriverManager initiation

Should solve issue #195

@jgelon jgelon mentioned this pull request Jul 1, 2022
Closed
rosolko
rosolko approved these changes Aug 15, 2022
View reviewed changes
Copy link
Owner

@rosolko rosolko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rosolko rosolko merged commit e88d918 into rosolko:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosolko rosolko rosolko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jgelon @rosolko