Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set download directory for webDrivers ( #167 ) #192

Merged
merged 3 commits into from Jun 27, 2022

Conversation

DSPaul
Copy link
Contributor

@DSPaul DSPaul commented Jun 11, 2022

Adds a new constructor for DriverManager that takes a path where the drivers should be downloaded to.
Current directory remains the default. Addresses #167.

@rosolko rosolko merged commit d555221 into rosolko:master Jun 27, 2022
@DSPaul
Copy link
Contributor Author

DSPaul commented Jun 29, 2022

Thank you for merging but in commit 9ce6c2f you changed the new constructor from public DriverManager(string downloadDirectory):this() to public DriverManager(string downloadDirectory) which causes the default constructor to no longer be called, which results in the DriverManager not having a BinaryService or a VariableService, which in turn causes it to crash when you try to use it.

There is no way to set these services outside the constructor because they are private, making the new constructor unusable and thus this entire PR. It is also the only thing you didn't revert in commit 75fa65e so maybe it's just an unintentional oversight. I can open a new PR if you want but the fix is pretty straightforward, just change it back. Unless there is a good reason to remove it that I'm not seeing, I would love to know.

@rosolko
Copy link
Owner

rosolko commented Jun 29, 2022

@DSPaul Yes, my fault, change it by mistake. Will fix it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants