Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver download not extracting all necessary files #113

Open
zthun opened this issue Dec 8, 2020 · 0 comments
Open

Driver download not extracting all necessary files #113

zthun opened this issue Dec 8, 2020 · 0 comments

Comments

@zthun
Copy link

zthun commented Dec 8, 2020

Platform: MacOS Big Sur (11.0.1)
Browser: Microsoft Edge (87.0.664.55)
Version: 2.11.0

Description

When using edge between version 86 and 87 (latest stable release), the download of the zip file does not include all of the necessary files when running. The file structure on OSX for edge looks like this:

  • Driver_Notes
    • credits.html
    • LICENSE
  • libc++.dynlib
  • msedgedriver

In the output bin folder, it looks like this:

  • bin
    • Edge
      • X64
        • msedgedriver

This crashes because it's missing libc++.dynlib. The following is where the bug is actually located:

using (var zip = ZipFile.Open(path, ZipArchiveMode.Read))
            {
                foreach (var entry in zip.Entries)
                {
                    if (entry.Name == name)
                    {
                        entry.ExtractToFile(destination, true);
                    }
                }
            }

The check for entry.Name is what is killing it. Removing that check should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants