Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NullableContextOptions optional #313

Open
kirides opened this issue Dec 9, 2019 · 2 comments
Open

Make NullableContextOptions optional #313

kirides opened this issue Dec 9, 2019 · 2 comments

Comments

@kirides
Copy link
Contributor

kirides commented Dec 9, 2019

I would like to have the NullableContextOptions optional, akin to "Optimized"-builds. E.g. a checkbox for "NullableContextOptions"

@kirides
Copy link
Contributor Author

kirides commented Dec 10, 2019

If someone were to implement this

  1. should the parameter be passed using ExecutionHost.ExecuteAsync(..., nullableContextOptions)
  2. or should a new _executionHost be created?
  3. or do we set a property on the _executionHost every time we call NullableContextOptions_set(value) (property set)

@aelij
Copy link
Member

aelij commented Dec 13, 2019

Since it can change every execution, it should be the first option (like optimizationLevel).
But this is not enough. The design-time build also needs to be configured (see RoslynHost and UpdateDocument).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants