Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converter "options" key missing should not produce notice #190

Closed
rosell-dk opened this issue Jun 15, 2019 · 0 comments
Closed

Converter "options" key missing should not produce notice #190

rosell-dk opened this issue Jun 15, 2019 · 0 comments
Assignees
@rosell-dk
Milestone
2.0.1

Comments

@rosell-dk
Copy link
Owner

rosell-dk commented Jun 15, 2019 •
edited

The converters option allows an item to be an array with two keys: "converter" and "options".
If the "options" key is missing, you currently get a notice and a warning:

Notice: Undefined index: options in [doc-root]/wp-content/plugins/webp-express/vendor/rosell-dk/webp-convert/src/Convert/Converters/Stack.php, line 159, PHP 7.1.30 (Linux)

Warning: array_merge() [function.array-merge]: Argument #2 is not an array in [doc-root]/wp-content/plugins/webp-express/vendor/rosell-dk/webp-convert/src/Convert/Converters/Stack.php, line 169, PHP 7.1.30 (Linux)

Check that the "options" key exists. If not, set to empty array
@rosell-dk rosell-dk added this to the 2.0.1 milestone Jun 15, 2019
@rosell-dk rosell-dk self-assigned this Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosell-dk rosell-dk

Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
1 participant
@rosell-dk