Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watchdog 1.0.0 drops dependency on pathtools #152

Closed
tschoonj opened this issue Dec 18, 2020 · 1 comment
Closed

Watchdog 1.0.0 drops dependency on pathtools #152

tschoonj opened this issue Dec 18, 2020 · 1 comment
Assignees
@LAShemilt

Comments

@tschoonj
Copy link
Contributor

We use pathtools for pattern matching in a couple of places, and should be easy to replace with an implementation based on pathlib, same as watchdog now does. Pathtools is essentially unmaintained and it would be good to get rid of it.

At the very least we should add an explicit dependency on pathtools in the meta.yaml and setup.cfg files for now until all traces of this package have been removed from our codebase.

For inspiration have a look at gorakhargosh/watchdog#556 and links therein.
tschoonj added a commit that referenced this issue Dec 18, 2020
@tschoonj
Add pathtools as an explicit dependency
364ff86 
See #152
@tschoonj tschoonj mentioned this issue Dec 18, 2020
Merged
@LAShemilt LAShemilt self-assigned this Dec 23, 2020
@LAShemilt LAShemilt mentioned this issue Dec 23, 2020
Merged
@tschoonj
Copy link
Contributor Author

Closed in #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LAShemilt LAShemilt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tschoonj @LAShemilt