{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":127306752,"defaultBranch":"rolling","name":"rosbag2","ownerLogin":"ros2","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-03-29T14:54:57.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3979232?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717826831.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"f0d475e31d4bff724395c9727d166d18c7ee7b59","ref":"refs/heads/mergify/bp/jazzy/pr-1697","pushedAt":"2024-06-08T06:07:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"Add bindings for LocalMessageDefinitionSource (#1697)\n\n* Add bindings for LocalMessageDefinitionSource\n\nSigned-off-by: methylDragon <methylDragon@gmail.com>\n\n* Fix pyi interface definitions\n\nSigned-off-by: methylDragon <methylDragon@gmail.com>\n\n* Update rosbag2_py/src/rosbag2_py/_message_definitions.cpp\n\nCo-authored-by: Michael Orlov <michael.orlov@apex.ai>\nSigned-off-by: methylDragon <methylDragon@gmail.com>\n\n---------\n\nSigned-off-by: methylDragon <methylDragon@gmail.com>\nCo-authored-by: Michael Orlov <michael.orlov@apex.ai>\n(cherry picked from commit fbb08d04d2c07ac48187b58c9bec66a33cd0cd5f)","shortMessageHtmlLink":"Add bindings for LocalMessageDefinitionSource (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2339501409\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ros2/rosbag2/issues/1697\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ros2/rosbag2/pull/1697/hovercard\" href=\"https://github.com/ros2/rosbag2/pull/1697\">#1697</a>)"}},{"before":"a2e984c0357c20e5e0f798551715b9affa74bc77","after":null,"ref":"refs/heads/ch3/message_definition_source_pybind","pushedAt":"2024-06-08T05:05:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"methylDragon","name":"methylDragon","path":"/methylDragon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20265670?s=80&v=4"}},{"before":"0f216c892d70726bcd2b1ea127953247e5e40656","after":"fbb08d04d2c07ac48187b58c9bec66a33cd0cd5f","ref":"refs/heads/rolling","pushedAt":"2024-06-08T05:05:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"methylDragon","name":"methylDragon","path":"/methylDragon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20265670?s=80&v=4"},"commit":{"message":"Add bindings for LocalMessageDefinitionSource (#1697)\n\n* Add bindings for LocalMessageDefinitionSource\r\n\r\nSigned-off-by: methylDragon <methylDragon@gmail.com>\r\n\r\n* Fix pyi interface definitions\r\n\r\nSigned-off-by: methylDragon <methylDragon@gmail.com>\r\n\r\n* Update rosbag2_py/src/rosbag2_py/_message_definitions.cpp\r\n\r\nCo-authored-by: Michael Orlov <michael.orlov@apex.ai>\r\nSigned-off-by: methylDragon <methylDragon@gmail.com>\r\n\r\n---------\r\n\r\nSigned-off-by: methylDragon <methylDragon@gmail.com>\r\nCo-authored-by: Michael Orlov <michael.orlov@apex.ai>","shortMessageHtmlLink":"Add bindings for LocalMessageDefinitionSource (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2339501409\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ros2/rosbag2/issues/1697\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ros2/rosbag2/pull/1697/hovercard\" href=\"https://github.com/ros2/rosbag2/pull/1697\">#1697</a>)"}},{"before":"0b6d099f71ca618d002279ddf20c7c79b9bac97f","after":"a2e984c0357c20e5e0f798551715b9affa74bc77","ref":"refs/heads/ch3/message_definition_source_pybind","pushedAt":"2024-06-07T22:40:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"methylDragon","name":"methylDragon","path":"/methylDragon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20265670?s=80&v=4"},"commit":{"message":"Update rosbag2_py/src/rosbag2_py/_message_definitions.cpp\n\nCo-authored-by: Michael Orlov <michael.orlov@apex.ai>\nSigned-off-by: methylDragon <methylDragon@gmail.com>","shortMessageHtmlLink":"Update rosbag2_py/src/rosbag2_py/_message_definitions.cpp"}},{"before":"301a21dc92f46e50c67e2f41e00a31118441258c","after":"0b6d099f71ca618d002279ddf20c7c79b9bac97f","ref":"refs/heads/ch3/message_definition_source_pybind","pushedAt":"2024-06-07T20:10:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"methylDragon","name":"methylDragon","path":"/methylDragon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20265670?s=80&v=4"},"commit":{"message":"Fix pyi interface definitions\n\nSigned-off-by: methylDragon <methylDragon@gmail.com>","shortMessageHtmlLink":"Fix pyi interface definitions"}},{"before":"da119925a0cef83fb57f89f892bba6e0a52455e1","after":null,"ref":"refs/heads/ch3/remove_vscode","pushedAt":"2024-06-07T18:55:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"methylDragon","name":"methylDragon","path":"/methylDragon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20265670?s=80&v=4"}},{"before":"ef66ee145cb4e74b4504d4806445cad8ad953390","after":"0f216c892d70726bcd2b1ea127953247e5e40656","ref":"refs/heads/rolling","pushedAt":"2024-06-07T18:55:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"methylDragon","name":"methylDragon","path":"/methylDragon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20265670?s=80&v=4"},"commit":{"message":"Add vscode gitignore rule and remove vscode folder (#1698)\n\nSigned-off-by: methylDragon <methylDragon@gmail.com>","shortMessageHtmlLink":"Add vscode gitignore rule and remove vscode folder (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2339504678\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ros2/rosbag2/issues/1698\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ros2/rosbag2/pull/1698/hovercard\" href=\"https://github.com/ros2/rosbag2/pull/1698\">#1698</a>)"}},{"before":"3d238dfe1b913e11ad334a48aa4988b480ff66b7","after":"301a21dc92f46e50c67e2f41e00a31118441258c","ref":"refs/heads/ch3/message_definition_source_pybind","pushedAt":"2024-06-07T03:28:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"methylDragon","name":"methylDragon","path":"/methylDragon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20265670?s=80&v=4"},"commit":{"message":"Add bindings for LocalMessageDefinitionSource\n\nSigned-off-by: methylDragon <methylDragon@gmail.com>","shortMessageHtmlLink":"Add bindings for LocalMessageDefinitionSource"}},{"before":"3f18a67387bedb2195fcbe40dae359fe15023a3d","after":"da119925a0cef83fb57f89f892bba6e0a52455e1","ref":"refs/heads/ch3/remove_vscode","pushedAt":"2024-06-07T03:26:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"methylDragon","name":"methylDragon","path":"/methylDragon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20265670?s=80&v=4"},"commit":{"message":"Add vscode gitignore rule and remove vscode folder\n\nSigned-off-by: methylDragon <methylDragon@gmail.com>","shortMessageHtmlLink":"Add vscode gitignore rule and remove vscode folder"}},{"before":null,"after":"3f18a67387bedb2195fcbe40dae359fe15023a3d","ref":"refs/heads/ch3/remove_vscode","pushedAt":"2024-06-07T03:25:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"methylDragon","name":"methylDragon","path":"/methylDragon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20265670?s=80&v=4"},"commit":{"message":"Add vscode gitignore rule\n\nSigned-off-by: methylDragon <methylDragon@gmail.com>","shortMessageHtmlLink":"Add vscode gitignore rule"}},{"before":"4131ef12d9648a0811ffe2ed06c242fa05e95892","after":"3d238dfe1b913e11ad334a48aa4988b480ff66b7","ref":"refs/heads/ch3/message_definition_source_pybind","pushedAt":"2024-06-07T03:23:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"methylDragon","name":"methylDragon","path":"/methylDragon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20265670?s=80&v=4"},"commit":{"message":"Add bindings for LocalMessageDefinitionSource\n\nSigned-off-by: methylDragon <methylDragon@gmail.com>","shortMessageHtmlLink":"Add bindings for LocalMessageDefinitionSource"}},{"before":null,"after":"4131ef12d9648a0811ffe2ed06c242fa05e95892","ref":"refs/heads/ch3/message_definition_source_pybind","pushedAt":"2024-06-07T03:19:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"methylDragon","name":"methylDragon","path":"/methylDragon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20265670?s=80&v=4"},"commit":{"message":"Add bindings for LocalMessageDefinitionSource\n\nSigned-off-by: methylDragon <methylDragon@gmail.com>","shortMessageHtmlLink":"Add bindings for LocalMessageDefinitionSource"}},{"before":"1fab7dd6cf1028f47c0cb48481bcc8a4a99af88d","after":"5016a0da941f019566ab91b90d394d4d6471b82f","ref":"refs/heads/morlov/bugfix-for-bag_split_callbacks-with-compression","pushedAt":"2024-06-07T02:31:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"MichaelOrlov","name":"Michael Orlov","path":"/MichaelOrlov","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7294722?s=80&v=4"},"commit":{"message":"Add debug info to the flaky \"can_record_again_after_stop\" test\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>","shortMessageHtmlLink":"Add debug info to the flaky \"can_record_again_after_stop\" test"}},{"before":"87d7ed8be71a2e051ed052a40e9d9c3593ce734d","after":"1fab7dd6cf1028f47c0cb48481bcc8a4a99af88d","ref":"refs/heads/morlov/bugfix-for-bag_split_callbacks-with-compression","pushedAt":"2024-06-07T01:21:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"MichaelOrlov","name":"Michael Orlov","path":"/MichaelOrlov","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7294722?s=80&v=4"},"commit":{"message":"Add tests for splint event callbacks when using file and msg compression\n\n - Added \"split_event_calls_callback_msg_compression\" and\n\"split_event_calls_callback_file_compression\" uit tests\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>","shortMessageHtmlLink":"Add tests for splint event callbacks when using file and msg compression"}},{"before":"1e9d8df7f222224e1761a5bac9637dd852acc35a","after":"87d7ed8be71a2e051ed052a40e9d9c3593ce734d","ref":"refs/heads/morlov/bugfix-for-bag_split_callbacks-with-compression","pushedAt":"2024-06-07T00:45:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"MichaelOrlov","name":"Michael Orlov","path":"/MichaelOrlov","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7294722?s=80&v=4"},"commit":{"message":"Add \"SequentialCompressionWriterTest::split_event_calls_callback\"\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>","shortMessageHtmlLink":"Add \"SequentialCompressionWriterTest::split_event_calls_callback\""}},{"before":"b1d93b12b033564a52fba3756d3837fc614e0e25","after":null,"ref":"refs/heads/mergify/bp/iron/pr-1557","pushedAt":"2024-06-06T06:20:47.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"delete-merged-branch[bot]","name":null,"path":"/apps/delete-merged-branch","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/14757?s=80&v=4"}},{"before":"605064870fcbb7af1400a45659a0893c0d78b694","after":"fd22add2c4ab2420e0c7896257a2f6989a35ddc5","ref":"refs/heads/iron","pushedAt":"2024-06-06T06:20:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"MichaelOrlov","name":"Michael Orlov","path":"/MichaelOrlov","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7294722?s=80&v=4"},"commit":{"message":"[iron] Gracefully handle SIGINT and SIGTERM signals for play and burst CLI (backport #1557) (#1690)\n\n* Gracefully handle SIGINT and SIGTERM signals for play and burst CLI (#1557)\r\n\r\n* Gracefully handle SIGINT and SIGTERM signals for play and burst CLI\r\n\r\n- Intercept signals to call Player::stop() instead of relying on the\r\nrclcpp::shutdown() in default signal handlers.\r\n- Also added static Player::Cancel() method.\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n\r\n* Add test_play_cancel to the test_transport.py\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n\r\n* Add missing imports in test_transport.py\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n\r\n* Regenerate Python stub files (.pyi) after altering API\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n\r\n* Add call for original deferred signal handler for Player and Recorder\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n\r\n---------\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n(cherry picked from commit 32bd5c3a9b5e4ff690682f04621d42f3151ba467)\r\n\r\n# Conflicts:\r\n#\trosbag2_py/rosbag2_py/_transport.pyi\r\n#\trosbag2_py/src/rosbag2_py/_transport.cpp\r\n#\trosbag2_transport/src/rosbag2_transport/player.cpp\r\n\r\n* Address merge conflicts\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n\r\n---------\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\nCo-authored-by: Michael Orlov <michael.orlov@apex.ai>","shortMessageHtmlLink":"[iron] Gracefully handle SIGINT and SIGTERM signals for play and burs…"}},{"before":"a79568a6c09281238c3ac458cf311ff7bbcbcc35","after":"b2277fa5a73c94fdc42c57dbf74e804fe9a61bd1","ref":"refs/heads/humble","pushedAt":"2024-06-06T06:20:24.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"MichaelOrlov","name":"Michael Orlov","path":"/MichaelOrlov","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7294722?s=80&v=4"},"commit":{"message":"[rosbag2] Fix typo to properly restore SIGINT hanlder (#1687)\n\nSigned-off-by: Eric Cousineau <eric.cousineau@tri.global>","shortMessageHtmlLink":"[rosbag2] Fix typo to properly restore SIGINT hanlder (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2329758743\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ros2/rosbag2/issues/1687\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ros2/rosbag2/pull/1687/hovercard\" href=\"https://github.com/ros2/rosbag2/pull/1687\">#1687</a>)"}},{"before":"5ff8f942682868b299d684c5809f9efc25c83e44","after":null,"ref":"refs/heads/mergify/bp/humble/pr-1557","pushedAt":"2024-06-04T23:41:41.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":"9b7eb217dc72dc18479f9cf760fc7b98b166d25d","after":"b1d93b12b033564a52fba3756d3837fc614e0e25","ref":"refs/heads/mergify/bp/iron/pr-1557","pushedAt":"2024-06-04T23:17:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"MichaelOrlov","name":"Michael Orlov","path":"/MichaelOrlov","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7294722?s=80&v=4"},"commit":{"message":"Address merge conflicts\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>","shortMessageHtmlLink":"Address merge conflicts"}},{"before":null,"after":"5ff8f942682868b299d684c5809f9efc25c83e44","ref":"refs/heads/mergify/bp/humble/pr-1557","pushedAt":"2024-06-04T18:20:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"Gracefully handle SIGINT and SIGTERM signals for play and burst CLI (#1557)\n\n* Gracefully handle SIGINT and SIGTERM signals for play and burst CLI\n\n- Intercept signals to call Player::stop() instead of relying on the\nrclcpp::shutdown() in default signal handlers.\n- Also added static Player::Cancel() method.\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\n\n* Add test_play_cancel to the test_transport.py\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\n\n* Add missing imports in test_transport.py\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\n\n* Regenerate Python stub files (.pyi) after altering API\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\n\n* Add call for original deferred signal handler for Player and Recorder\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\n\n---------\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\n(cherry picked from commit 32bd5c3a9b5e4ff690682f04621d42f3151ba467)\n\n# Conflicts:\n#\trosbag2_py/rosbag2_py/_transport.pyi\n#\trosbag2_py/src/rosbag2_py/_transport.cpp\n#\trosbag2_py/test/test_transport.py\n#\trosbag2_transport/src/rosbag2_transport/player.cpp","shortMessageHtmlLink":"Gracefully handle SIGINT and SIGTERM signals for play and burst CLI (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2109187841\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ros2/rosbag2/issues/1557\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ros2/rosbag2/pull/1557/hovercard\" href=\"https://github.com/ros2/rosbag2/pull/1557\">#…</a>"}},{"before":null,"after":"9b7eb217dc72dc18479f9cf760fc7b98b166d25d","ref":"refs/heads/mergify/bp/iron/pr-1557","pushedAt":"2024-06-04T18:19:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"Gracefully handle SIGINT and SIGTERM signals for play and burst CLI (#1557)\n\n* Gracefully handle SIGINT and SIGTERM signals for play and burst CLI\n\n- Intercept signals to call Player::stop() instead of relying on the\nrclcpp::shutdown() in default signal handlers.\n- Also added static Player::Cancel() method.\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\n\n* Add test_play_cancel to the test_transport.py\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\n\n* Add missing imports in test_transport.py\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\n\n* Regenerate Python stub files (.pyi) after altering API\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\n\n* Add call for original deferred signal handler for Player and Recorder\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\n\n---------\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\n(cherry picked from commit 32bd5c3a9b5e4ff690682f04621d42f3151ba467)\n\n# Conflicts:\n#\trosbag2_py/rosbag2_py/_transport.pyi\n#\trosbag2_py/src/rosbag2_py/_transport.cpp\n#\trosbag2_transport/src/rosbag2_transport/player.cpp","shortMessageHtmlLink":"Gracefully handle SIGINT and SIGTERM signals for play and burst CLI (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2109187841\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ros2/rosbag2/issues/1557\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ros2/rosbag2/pull/1557/hovercard\" href=\"https://github.com/ros2/rosbag2/pull/1557\">#…</a>"}},{"before":"97526b000422b3b52fea2e620f30315391ca9b3e","after":null,"ref":"refs/heads/mergify/bp/iron/pr-1592","pushedAt":"2024-06-04T18:17:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"delete-merged-branch[bot]","name":null,"path":"/apps/delete-merged-branch","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/14757?s=80&v=4"}},{"before":"44bfa7818692765664296246b2ef80dda9c1b389","after":"605064870fcbb7af1400a45659a0893c0d78b694","ref":"refs/heads/iron","pushedAt":"2024-06-04T18:17:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"MichaelOrlov","name":"Michael Orlov","path":"/MichaelOrlov","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7294722?s=80&v=4"},"commit":{"message":"[iron] Fix for false negative tests in rosbag2_py (backport #1592) (#1688)\n\n* Fix for false negative tests in rosbag2_py (#1592)\r\n\r\n* Fix for false negative tests in rosbag2_py\r\n\r\n-  wait_for(condition: Callable, timout) was incorrectly returning True\r\nafter the first iteration even if condition was false.\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n\r\n* Address review comments in regards bag_path optimization\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n\r\n---------\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n(cherry picked from commit 66af3999f145a8910b567a6ab48993c83410754e)\r\n\r\n# Conflicts:\r\n#\trosbag2_py/test/test_transport.py\r\n\r\n* Resolve merge conflicts\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n\r\n---------\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\nCo-authored-by: Michael Orlov <michael.orlov@apex.ai>","shortMessageHtmlLink":"[iron] Fix for false negative tests in rosbag2_py (backport <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2195776380\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ros2/rosbag2/issues/1592\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ros2/rosbag2/pull/1592/hovercard\" href=\"https://github.com/ros2/rosbag2/pull/1592\">#1592</a>) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2333830543\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ros2/rosbag2/issues/1688\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ros2/rosbag2/pull/1688/hovercard\" href=\"https://github.com/ros2/rosbag2/pull/1688\">#…</a>"}},{"before":"f414d480ed4ff725b0bfc2c053ed3e7ece15571f","after":null,"ref":"refs/heads/mergify/bp/humble/pr-1592","pushedAt":"2024-06-04T18:17:12.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"delete-merged-branch[bot]","name":null,"path":"/apps/delete-merged-branch","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/14757?s=80&v=4"}},{"before":"8c94497f4a13464538457d81433d85fa13c760a9","after":"a79568a6c09281238c3ac458cf311ff7bbcbcc35","ref":"refs/heads/humble","pushedAt":"2024-06-04T18:17:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"MichaelOrlov","name":"Michael Orlov","path":"/MichaelOrlov","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7294722?s=80&v=4"},"commit":{"message":"[humble] Fix for false negative tests in rosbag2_py (backport #1592) (#1689)\n\n* Fix for false negative tests in rosbag2_py (#1592)\r\n\r\n* Fix for false negative tests in rosbag2_py\r\n\r\n-  wait_for(condition: Callable, timout) was incorrectly returning True\r\nafter the first iteration even if condition was false.\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n\r\n* Address review comments in regards bag_path optimization\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n\r\n---------\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n(cherry picked from commit 66af3999f145a8910b567a6ab48993c83410754e)\r\n\r\n# Conflicts:\r\n#\trosbag2_py/test/test_transport.py\r\n\r\n* Resolve merge conflicts\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\n\r\n---------\r\n\r\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>\r\nCo-authored-by: Michael Orlov <michael.orlov@apex.ai>","shortMessageHtmlLink":"[humble] Fix for false negative tests in rosbag2_py (backport <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2195776380\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ros2/rosbag2/issues/1592\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ros2/rosbag2/pull/1592/hovercard\" href=\"https://github.com/ros2/rosbag2/pull/1592\">#1592</a>) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2333830674\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ros2/rosbag2/issues/1689\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ros2/rosbag2/pull/1689/hovercard\" href=\"https://github.com/ros2/rosbag2/pull/1689\">#…</a>"}},{"before":"58f66759ae10f3d0da5842e46d2baad28b46edbb","after":"7892bac37f20f1c4cb4e93522ef91d6d3c0e7f12","ref":"refs/heads/clalancette/remove-python-cmake-module","pushedAt":"2024-06-04T18:05:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"clalancette","name":"Chris Lalancette","path":"/clalancette","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/163000?s=80&v=4"},"commit":{"message":"Stop using python_cmake_module.\n\nWe really don't need it anymore, and can just use the\nbuiltin find_package(Python3).\n\nSigned-off-by: Chris Lalancette <clalancette@gmail.com>","shortMessageHtmlLink":"Stop using python_cmake_module."}},{"before":"514650ba81c8b3c1c5d73be79cb90509f2630208","after":"97526b000422b3b52fea2e620f30315391ca9b3e","ref":"refs/heads/mergify/bp/iron/pr-1592","pushedAt":"2024-06-04T16:03:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"MichaelOrlov","name":"Michael Orlov","path":"/MichaelOrlov","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7294722?s=80&v=4"},"commit":{"message":"Resolve merge conflicts\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>","shortMessageHtmlLink":"Resolve merge conflicts"}},{"before":"002d24cd6ab340bbcdfc1429e0300f46a23087fe","after":"f414d480ed4ff725b0bfc2c053ed3e7ece15571f","ref":"refs/heads/mergify/bp/humble/pr-1592","pushedAt":"2024-06-04T15:49:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"MichaelOrlov","name":"Michael Orlov","path":"/MichaelOrlov","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7294722?s=80&v=4"},"commit":{"message":"Resolve merge conflicts\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>","shortMessageHtmlLink":"Resolve merge conflicts"}},{"before":"ec88f139217d4d3182d41af7525bdcc7088716ec","after":"002d24cd6ab340bbcdfc1429e0300f46a23087fe","ref":"refs/heads/mergify/bp/humble/pr-1592","pushedAt":"2024-06-04T15:45:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"MichaelOrlov","name":"Michael Orlov","path":"/MichaelOrlov","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7294722?s=80&v=4"},"commit":{"message":"Resolve merge conflicts\n\nSigned-off-by: Michael Orlov <michael.orlov@apex.ai>","shortMessageHtmlLink":"Resolve merge conflicts"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEX8f9GQA","startCursor":null,"endCursor":null}},"title":"Activity · ros2/rosbag2"}