Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support snapshots repository #404

Open
christophebedard opened this issue May 30, 2021 · 0 comments
Open

Support snapshots repository #404

christophebedard opened this issue May 30, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@christophebedard
Copy link
Member

Description

This would allow users to use a specific snapshot (i.e. a specific distro at a specific datestamp, or the "final" sync for EOL distros).

See:

Related Issues

-

Completion Criteria

Users can configure the action to use distros x & y at sync datestamps X & Y from the snapshots repository.

Implementation Notes / Suggestions

Add a new snapshots input which is empty by default (current behaviour). Ignore the input/value if not on Ubuntu/Linux (or fail in that case?).

If the value is not empty, use the snapshots repository (http://snapshots.ros.org/${ROS_DISTRO}/${INPUT_SNAPSHOTS}/ubuntu) instead of the usual one (http://packages.ros.org/ros2/ubuntu).

If only one distro is declared with required-ros-distributions, use that value:

  with:
    required-ros-distributions: foxy
    snapshots: 2021-01-07

If multiple distros are declared with required-ros-distributions, expect a JSON object/dictionary:

  with:
    required-ros-distributions: noetic foxy
    snapshots: |
      {
        "foxy": "2021-01-07",
        "noetic": "2021-01-22"
      }

This will require some input validation.

Testing Notes / Suggestions

A job that uses the snapshots input once for a single distro and once for multiple distros/sync datestamps.

Unit tests for the snapshots input validation.

@christophebedard christophebedard added the enhancement New feature or request label May 30, 2021
@christophebedard christophebedard self-assigned this Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant