Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot open include file: 'sys/wait.h' #236

Open
norro opened this issue Aug 3, 2020 · 1 comment
Open

Cannot open include file: 'sys/wait.h' #236

norro opened this issue Aug 3, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@norro
Copy link

norro commented Aug 3, 2020

Description

Windows builds seem to miss the file sys/wait.h, resulting in builds of the package osrf_testing_tools_cpp (see, this PR for example) to fail. osrf_testing_tools_cpp builds without this issue in my local Windows 10 setup.

Expected Behavior

Setup provides all required files to build ROS 2 packages on Windows 10.

Actual Behavior

Build of ROS 2 package osrf_testing_tools_cpp fails on Windows 10 with:

fatal error C1083: Cannot open include file: 'sys/wait.h': No such file or directory [D:\a\system_modes\system_modes\ros_ws\build\osrf_testing_tools_cpp\src\test_runner\test_runner.vcxproj]
  ---Failed   <<< osrf_testing_tools_cpp

To Reproduce

  1. Enable ros-tooling actions for a ROS 2 package that depends on osrf_testing_tools_cpp
  2. Add ros-tooling/setup-ros and ros-tooling/action-ros-ci (ros-tooling/setup-ros@0.0.25 and ros-tooling/action-ros-ci@0.0.15 in my repo)
  3. Enable build for OS windows-latest

System

  • OS: windows-latest
  • ROS 2 Distro: foxy
  • find a complete setup that reproduces this error in the system modes repository.
@norro norro added the bug Something isn't working label Aug 3, 2020
@emersonknapp
Copy link
Contributor

I think we have seen this same issue sporadically on our action-ros-ci nightly windows builds. Needs further investigation.

rotu added a commit to rotu/osrf_testing_tools_cpp that referenced this issue Aug 24, 2020
@rotu
Change WIN32 to _WIN32
33adc3a 
This seems to have been a typo. The correct macro is `_WIN32` as seen elsewhere in this repo and as per the docs:

https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019

Possibly responsible for ros-tooling/setup-ros#236
@rotu rotu mentioned this issue Aug 24, 2020
Merged
wjwwood pushed a commit to osrf/osrf_testing_tools_cpp that referenced this issue Sep 11, 2020
@rotu
Change WIN32 to _WIN32 (#53)
264fa67 
This seems to have been a typo. The correct macro is `_WIN32` as seen elsewhere in this repo and as per the docs:

https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019

Possibly responsible for ros-tooling/setup-ros#236
@emersonknapp emersonknapp added bug Something isn't working and removed bug Something isn't working labels Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@norro @emersonknapp