Action ignores failed rosdep install

[bjsowa]

Description

When rosdep fails to install some dependencies, the action does not fail and instead tries to build the packages anyway.

Expected Behavior

I would expect the action to fail or at least an option to choose whether the action should fail fast.

Actual Behavior

The action does not fail.

[christophebedard]

We do indeed do || true with rosdep install to avoid making it fail the action:

action-ros-ci/src/action-ros-ci.ts

Line 188 in fcaebb7

)}" --rosdistro $DISTRO -y || true`;

It looks like this has been here since the very beginning: 6de5bca

In what instances is rosdep install failing for you?

[bjsowa]

In what instances is rosdep install failing for you?

I was trying to release my packages to Jazzy and incorrectly assumed all dependencies correctly resolve because the CI was passing.